Skip to content

Python Add the Amazon Neptune Python follow #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 26, 2025
Merged

Python Add the Amazon Neptune Python follow #7473

merged 32 commits into from
Jun 26, 2025

Conversation

scmacdon
Copy link
Contributor

@scmacdon scmacdon commented Jun 5, 2025

This pull request adds the Amazon Neptune Python follow

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon self-assigned this Jun 5, 2025
@scmacdon scmacdon added Python This issue relates to the AWS SDK for Python (boto3) Basics A basic code example showing the core actions for a particular service. Follow After Scouts, more languages are added to examples as Follows. labels Jun 5, 2025
@scmacdon scmacdon requested a review from beqqrry-aws June 6, 2025 19:59
@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Jun 10, 2025
rlhagerm
rlhagerm requested changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've made the high-level fixes and it matches the specification, I can do a full review.

@rlhagerm rlhagerm removed the On Call Review needed This work needs an on-call review label Jun 12, 2025
@scmacdon
Copy link
Contributor Author

The Hello and Scenario examples run as excepted. The tests have been refactored to follow other Python tests such as Keyspace. The Spec was updated to include SME contributed code examples.

rlhagerm
rlhagerm requested changes Jun 16, 2025
View reviewed changes
rlhagerm
rlhagerm reviewed Jun 23, 2025
View reviewed changes
rlhagerm
rlhagerm reviewed Jun 23, 2025
View reviewed changes
rlhagerm
rlhagerm reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder is missing the necessary requirements.txt file.

@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Jun 25, 2025
@brmur brmur added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Jun 26, 2025
@brmur brmur merged commit 74b08e4 into awsdocs:main Jun 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqqrry-aws beqqrry-aws beqqrry-aws approved these changes

@rlhagerm rlhagerm rlhagerm approved these changes

Assignees

@scmacdon scmacdon

Labels
Basics A basic code example showing the core actions for a particular service. Follow After Scouts, more languages are added to examples as Follows. On Call Review complete On call review complete Python This issue relates to the AWS SDK for Python (boto3)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scmacdon @beqqrry-aws @rlhagerm @brmur